Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: sentry-android-timber package sets sentry.java.android.timber as SDK name #1456

Merged
merged 4 commits into from
May 3, 2021

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented May 3, 2021

📜 Description

Fix: sentry-android-timber package sets sentry.java.android.timber as SDK name

💡 Motivation and Context

fixes #1175

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

CHANGELOG.md Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented May 3, 2021

Codecov Report

Merging #1456 (a556e8d) into main (5696370) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1456   +/-   ##
=========================================
  Coverage     75.87%   75.87%           
  Complexity     1901     1901           
=========================================
  Files           189      189           
  Lines          6499     6499           
  Branches        640      640           
=========================================
  Hits           4931     4931           
  Misses         1272     1272           
  Partials        296      296           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5696370...a556e8d. Read the comment docs.

@marandaneto marandaneto merged commit 2a966a4 into main May 3, 2021
@marandaneto marandaneto deleted the fix/timber-sdk-name branch May 3, 2021 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timber: report sdk.name=sentry.java.android.timber
3 participants